Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maurits/character sets #48

Closed

Conversation

mauritsvanrees
Copy link
Member

This builds on my PR #47, so that one should be merged first.
On top, there is currently one commit:

Support character sets.
Example: sr@Latn and sr@Cyrl will be added to language sr (Serbian).
See collective/plone.app.locales#326
You can choose which one to use by setting either sr@Latn or sr@Cyrl in environment variable zope_i18n_allowed_languages.

sr@Latn and sr@Cyrl will be added to language sr.
See collective/plone.app.locales#326
@icemac icemac changed the base branch from master to config-with-pure-python September 3, 2021 06:02
@icemac
Copy link
Member

icemac commented Sep 3, 2021

I changed the traget branch of this PR to config-with-pure-python (#47), so only the relevant commit shows up. After that branch is merged GitHub automatically changes the target branch to master.

@icemac
Copy link
Member

icemac commented Sep 3, 2021

Additionally I allowed coverage to be 99 % (via coveralls config.)

@icemac icemac requested a review from mgedmin September 3, 2021 06:07
@mauritsvanrees
Copy link
Member Author

I changed the traget branch of this PR to config-with-pure-python (#47), so only the relevant commit shows up. After that branch is merged GitHub automatically changes the target branch to master.

Ah, I didn't know it worked this way.

Since I closed the other PR in favour of a new one, let me do the same here.

@mauritsvanrees mauritsvanrees deleted the maurits/character-sets branch September 3, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants